• Sathya Gunasekaran's avatar
    Revert "[builtins] Move non-JS linkage builtins code objects into RO_SPACE" · f1ebde88
    Sathya Gunasekaran authored
    This reverts commit 83f8464f.
    
    Reason for revert: speculative revert for blink linux failure
    https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/1272
    
    Original change's description:
    > [builtins] Move non-JS linkage builtins code objects into RO_SPACE
    > 
    > Creates an allow-list of builtins that can still go in code_space
    > including all TFJ builtins and a small manual list that should be pared
    > down in the future.
    > 
    > For builtins that go in RO_SPACE a Code object is created that contains
    > no code at all (shrinking its size from 96 bytes to 64 bytes on x64),
    > but is there to allow the runtime to continue to work since it expects
    > a Code object.
    > 
    > This reduces code_space from ~152k to ~40k (-112k) and increases
    > read_only_space from 33k to 108k (+75k) in the snapshot.
    > 
    > Bug: v8:7464, v8:9821, v8:9338, v8:8127
    > Change-Id: Icc8bfc722bb267a2bcc17e2f1e27bef7f02f2376
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795358
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#64377}
    
    TBR=mstarzinger@chromium.org,jgruber@chromium.org,delphick@chromium.org
    
    Change-Id: I4cf38e9370280acdd2de718ca527776ebc509003
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7464, v8:9821, v8:9338, v8:8127
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868621Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64383}
    f1ebde88
assembler.cc 9.09 KB