• Nico Hartmann's avatar
    Revert "[turbofan] Improve equality on NumberOrOddball" · f4b98cc6
    Nico Hartmann authored
    This reverts commit 6204768b.
    
    Reason for revert: A number of Clusterfuzz reports (e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=1079474)
    
    Original change's description:
    > [turbofan] Improve equality on NumberOrOddball
    > 
    > This CL cleans up CompareOperationFeedback by replacing it with a
    > composable set of flags. The interpreter is changed to collect
    > more specific feedback for abstract equality, especially if oddballs
    > are involved.
    > 
    > TurboFan is changed to construct SpeculativeNumberEqual operator
    > instead of the generic JSEqual in many more cases. This change has
    > shown a local speedup of a factor of 3-10, because the specific
    > operator is way faster than calling into the generic builtin, but
    > it also enables additional optimizations, further improving
    > runtime performance.
    > 
    > Bug: v8:5660
    > Change-Id: I856752caa707e9a4f742c6e7a9c75552fb431d28
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162854
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67645}
    
    TBR=rmcilroy@chromium.org,neis@chromium.org,mythria@chromium.org,nicohartmann@chromium.org
    
    Change-Id: I3410310ed2b1ff2eaee70c1b91c3151d35866108
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:5660
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190414Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67673}
    f4b98cc6
simplified-lowering.cc 188 KB