• Manos Koukoutos's avatar
    [wasm][turbofan] Inline before loop unrolling · b9855173
    Manos Koukoutos authored
    We switch the order of inlining and loop unrolling optimizations. This
    gives small improvements to wasm-gc benchmarks.
    Changes:
    - Change the loop analysis algorithm to accept loops directly connected
      to the graph's end. This is required because some nodes in an inlined
      function, such as tail calls, might be directly connected to the outer
      function's end without an intervening LoopExit node.
    - Based on the above, skip emitting loop exits for some Throw nodes in
      WasmGraphBuildingInterface.
    - Introduce WasmInliningPhase, add it before loop unrolling. Remove
      inlining from WasmOptimizationPhase.
    - Handle graph terminators in loop unrolling.
    - Add loops in the inlined function to the callers loop_infos.
    Drive-by:
    - Allow more wasm builtins in unrolled loops.
    - Reduce inlining parameters to reflect that functions are now slightly
      smaller during inlining, as no unrolling has taken place yet.
    
    Bug: v8:12166
    Change-Id: Iadd6b2f75170aa153ca1efb47fbb0d185c2b8371
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329783Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78394}
    b9855173
graph-builder-interface.cc 70.1 KB