• Clemens Backes's avatar
    [wasm] Split decoder functions · d696c37d
    Clemens Backes authored
    Instead of having one method with a big switch, and specializing that
    method for each single opcode, we now have one proper method per opcode.
    This makes the code way more readable, and also reduces the compile time
    of liftoff-compiler.cc significantly.
    
    Unfortunately, we cannot use template specializations for this, since
    GCC does not support specializing the methods within an unspecialized
    templated class.
    Hence, we need to have another dispatch per opcode when generating the
    opcode handler table. I left a comment explaining why we do it this way.
    The upside of this is that we get nicer method names.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10576
    Change-Id: I8c7026177490893711c999217eeb1e4f2fbb5e36
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282533
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68732}
    d696c37d
template-utils.h 3.73 KB