• Clemens Backes's avatar
    [wasm] Improve code size estimates · aadf812c
    Clemens Backes authored
    UMA data shows that we currently still allocate up to ten code spaces
    per module. This is because the code size estimates are vastly off,
    especially if both Liftoff and TurboFan is being used.
    Also, code sizes differ by platform.
    
    This CL adds more logic to the {EstimateNativeModuleCodeSize} function
    to distinguish Liftoff and TurboFan, and to use different constants per
    platform. A largeish comment explains how the numbers were generated,
    and that they are an extreme over-generalization. However, without
    further information about the module, this is the best we can do.
    After all, being off even by a factor of two does not hurt too much, as
    explained in the comment.
    
    R=jkummerow@chromium.org
    
    Change-Id: Icd178f5f4d0c7c8fa29b11b6eff7d14e64a1af1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910102
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64913}
    aadf812c
wasm-serialization.cc 24.2 KB