• Camillo Bruni's avatar
    Revert "[test][d8] Add d8.log.getAndStop helper" · 8bf237dd
    Camillo Bruni authored
    This reverts commit 95aa697b.
    
    Reason for revert: breaks under tsan
    
    Original change's description:
    > [test][d8] Add d8.log.getAndStop helper
    > 
    > The new helper function allows us to write tests for log parsing
    > without the need to first generating a log file. This makes it easier
    > to spot errors when the log format changes.
    > 
    > - Add d8 global variable
    > - Add file_name accessor to Logger and Log classes
    > - Change OS::LogFileOpenMode to w+ / wb+
    > - Use separate Log::WriteLogHeader method
    > - Remove unused logger_ instance variable from Log
    > 
    > Bug: v8:10644
    > Change-Id: Ifc7e35aa4e91b3f01f0847843263946e085944c3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387563
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69715}
    
    TBR=mlippautz@chromium.org,cbruni@chromium.org,gsathya@chromium.org,verwaest@chromium.org
    
    Change-Id: Iad47d2f1e3391cae3c2f8c9e6c904c43925e1671
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10644
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2396080Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69717}
    8bf237dd
log.h 18 KB