• Simon Zünd's avatar
    [inspector] Reset the async task stack when resetting the context group · 50f84564
    Simon Zünd authored
    This CL fixes an issue with async stacks. The async task stack is not
    torn down between page navigations or reloads. The result is that
    any new async tasks are stacked on top of the old pages async task
    stack.
    
    This was not prominent until now for two reasons:
      1) Async tasks created in blink are always finished as long as
         destructors have time to run.
      2) When V8 is terminated while running the micro task queue also
         all async tasks created for Promises (including `await`) are
         cleaned up properly.
    
    Introducing the stack tagging API made it more common for having
    unfinished async tasks open outside the MTQ, which left the
    async task stack non-empty during navigation.
    
    This CL fixes this problem by clearing out all the async task
    and async stack data structures for a context group when that
    context group is reset.
    
    R=bmeurer@chromium.org, victorporof@chromium.org
    
    Fixed: chromium:1328785
    Change-Id: Iee0c3c4a55f66e643829dae3726dc03c735da1dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666620Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80741}
    50f84564
inspector.status 23.7 KB