• Benedikt Meurer's avatar
    [turbofan] Add IC support for Call/ConstructWithSpread. · 5ee1b7ad
    Benedikt Meurer authored
    Properly hook up the (existing) IC slots for the CallWithSpread and
    ConstructWithSpread bytecodes, and change the interpreter to collect
    feedback (call counts and regular target function feedback) for those.
    There's no integration with the Array constructor yet, since that
    requires some yak shaving to thread through the AllocationSite to the
    Array constructor stub. Once we have a solution for that, we can also
    remove the current code duplication in the Call/Construct IC logic.
    
    Also properly hook up the newly available feedback in TurboFan. This
    will fix not only the missing target feedback, but more importantly
    the tear-up decisions for optimization are correct now in the presence
    of spread calls, and even more importantly the inlining heurstic has
    proper call frequencies for those.
    
    Some follow-up changes will be necessary to make sure we use the
    feedback even for corner cases that aren't handled properly yet. Also
    we should consider collecting feedback about the map of the spread
    at some point to be able to always inline the spread calls.
    
    Bug: v8:6399, v8:6527, v8:6630
    Change-Id: I818dbcb411fd3951d8e9d31f5d7e794f8d60fa00
    Reviewed-on: https://chromium-review.googlesource.com/582647Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46832}
    5ee1b7ad
interpreter-assembler.cc 57.6 KB