• Shu-yu Guo's avatar
    Revert "Reland "heap: Force incremental marking in C++ only workloads"" · 8d996244
    Shu-yu Guo authored
    This reverts commit 7d4c264e.
    
    Reason for revert: Blocking chromium roll, failures in ASAN unittests:
    https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_asan_rel_ng/1104768/test-results
    
    Original change's description:
    > Reland "heap: Force incremental marking in C++ only workloads"
    >
    > This is a reland of commit 4fde3328
    >
    > Most recent fix made Oilpan aware of --single-threaded-gc which
    > is necessary as GCs are more eagerly scheduled in tests.
    >
    > Original change's description:
    > > heap: Force incremental marking in C++ only workloads
    > >
    > > ... when above a certain minimum threshold. This is to guard against
    > > memory running away in scenarios where the JS heap is empty and
    > > there's only high throughput C++ allocations that don't allow for a
    > > memory reducer GC to kick in.
    > >
    > > This logic should be revisited after Oilpan's young generation
    > > collector is implemented which may allow switching to a more efficient
    > > shrinking strategy for initial heap setup.
    > >
    > > Bug: chromium:1029379, chromium:1300028, chromium:1300492
    > > Change-Id: I93924fc2fe77d6226c29358d3afb1cc9d6fbf3b1
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3484319
    > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#79255}
    >
    > Bug: chromium:1029379, chromium:1300028, chromium:1300492
    > Change-Id: Ia0c443248b951240cce6dbe1f68581ff1061a7d9
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500301
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79327}
    
    Bug: chromium:1029379, chromium:1300028, chromium:1300492
    Change-Id: I3fd0a5d4ded7d3ce7cd74a50a11b3a0367477d06
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500656
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Owners-Override: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#79335}
    8d996244
heap.cc 264 KB