• mythria's avatar
    Revert of [Interpreter] Implements calls through CallICStub in the... · eb358178
    mythria authored
    Revert of [Interpreter] Implements calls through CallICStub in the interpreter. (patchset #15 id:270001 of https://codereview.chromium.org/1688283003/ )
    
    Reason for revert:
    It is not a good idea to call CallICStub from the builtin. It might be sensitive to the frame structure. Constructing a internal frame might cause problems. It is much better to inline the code  related to the type feedback vector into the builtin.
    
    Original issue's description:
    > [Interpreter] Implements calls through CallICStub in the interpreter.
    >
    > Calls are implemented through CallICStub to collect type feedback. Adds
    > a new builtin called InterpreterPushArgsAndCallIC that pushes the
    > arguments onto stack and calls CallICStub.
    >
    > Also adds two new bytecodes CallIC and CallICWide to indicate calls have to
    > go through CallICStub.
    >
    > MIPS port contributed by balazs.kilvady.
    >
    > BUG=v8:4280, v8:4680
    > LOG=N
    >
    > Committed: https://crrev.com/20362a2214c11a0f2ea5141b6a79e09458939cec
    > Cr-Commit-Position: refs/heads/master@{#34244}
    
    TBR=rmcilroy@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4280, v8:4680
    
    Review URL: https://codereview.chromium.org/1731253003
    
    Cr-Commit-Position: refs/heads/master@{#34252}
    eb358178
interpreter-assembler.h 8.01 KB