• cbruni's avatar
    [left-trimming] Avoid creating duplicate handles in builtins.cc · 6dd16e8e
    cbruni authored
    EnsureJSArrayWithWritableFastElements
    
    Having several handles pointing to the backing store of an array that gets
    left-trimmed might cause the gc to start marking a stale-handle still pointing
    to the old backing-store start. By introducing a separate handle scope for
    EnsureJSArrayWithWritableFastElements we avoid this issue. Additionally a
    SLOW_DCHECK in Heap::LeftTrimFixedArray ensurse that there are no more than one
    active handle pointing to the backing store.
    
    BUG=chr:585787
    LOG=n
    
    Review URL: https://codereview.chromium.org/1699733003
    
    Cr-Commit-Position: refs/heads/master@{#34022}
    6dd16e8e
builtins.cc 155 KB