• Daniel Bevenius's avatar
    [tools] Add error handling to no_arg_cmd · fcac59ad
    Daniel Bevenius authored
    Currently, it can be little difficult to understand why a command in
    lldb-commands.py stops working. For example, at the moment running the
    jlh command results in an empty line:
    
    $ lldb --one-line "command script import ../../tools/lldb_commands.py" \
         v8_hello_world
    (lldb) br s -f hello-world.cc -l 49
    (lldb) jlh script
    
    (lldb)
    
    With this commit this would instead display the following error message:
    
    (lldb) jlh script
    Failed to evaluate command
    _v8_internal_Print_Object(*(v8::internal::Object**)(*(void*)(script))) :
    error: cannot cast from type 'v8::Local<v8::Script>' to pointer type
    'void *'
    
    The output is really only two lines but I've wrapped the lines here so
    they don't exceed the 72 column width. I'll follow up with a commit to
    fix the issue reported.
    
    Change-Id: I634a412b616dad7cadd74dce36418d27c1997777
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083477Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68093}
    fcac59ad
lldb_commands.py 4.28 KB