• Mircea Trofin's avatar
    Revert "Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM""" · 3a0704f7
    Mircea Trofin authored
    This reverts commit 1835b4b1.
    
    Reason for revert: This has a perf regression, wasn't ready just yet.
    
    Original change's description:
    > Revert "Revert "[wasm] Throttle the amount of unfinished work to avoid OOM""
    > 
    > This reverts commit 4ee49181.
    > 
    > Reason for revert: Fix: in d8, blocking all the bg threads starves the GC.
    > 
    > Original change's description:
    > > Revert "[wasm] Throttle the amount of unfinished work to avoid OOM"
    > > 
    > > This reverts commit 1280954d.
    > > 
    > > Reason for revert: Speculative, GC stress bots started taking much longer after this change.
    > > 
    > > Original change's description:
    > > > [wasm] Throttle the amount of unfinished work to avoid OOM
    > > > 
    > > > It is possible that the foreground task is unable to clear the
    > > > scheduled unfinished work, eventually leading to an OOM.
    > > > 
    > > > We use either code_range on 64 bit, or the capacity of the code space,
    > > > as a heuristic for how much memory to use for compilation.
    > > > 
    > > > Bug: v8:6492, chromium:732010
    > > > Change-Id: I1e4c0825351a42fa0b8369ccc41800ac3445563d
    > > > Reviewed-on: https://chromium-review.googlesource.com/535017
    > > > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    > > > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#46017}
    > > 
    > > TBR=bradnelson@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    > > 
    > > Change-Id: I8883cee7f77667530bc50f91bfb468c485e6f7f2
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: v8:6492, chromium:732010
    > > Reviewed-on: https://chromium-review.googlesource.com/540270
    > > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#46020}
    > 
    > TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    > 
    > Change-Id: I1e7a1d0202c3161f9a7139e8895eebf472473ad3
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:6492, chromium:732010
    > Reviewed-on: https://chromium-review.googlesource.com/540841
    > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#46022}
    
    TBR=bradnelson@chromium.org,bbudge@chromium.org,mtrofin@chromium.org,mtrofin@google.com,ahaas@chromium.org
    
    Change-Id: Ic1351325173b233be3972ff3c159c035838fa963
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6492, chromium:732010
    Reviewed-on: https://chromium-review.googlesource.com/540842Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46023}
    3a0704f7
pipeline.cc 73.9 KB