• Frank Tang's avatar
    Revert "[Temporal] Use double/int32_t instead of int64_t for duration parsing" · 8ff03afe
    Frank Tang authored
    This reverts commit a165e82e.
    
    Reason for revert: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/objects/js-temporal-objects.cc:3837:22  
    
    Original change's description:
    > [Temporal] Use double/int32_t instead of int64_t for duration parsing
    >
    > Use double instead of int64_t and int32_t in duration parsing result
    > so we can parse very large duration fields as infinity and throw RangeError in later stages. The three fractional parts can hold up value from 0 to 999,999,999 so we use int32_t to hold it. Other part could be infinity so we use double to hold it. Also rearrange the order of the three int32_t in the struct ParsedISO8601Duration after all the double
    >
    > Bug: v8:11544
    > Change-Id: I7e5b02f7c7bbb60997f1419f016aed61dd3e0d6c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840761
    > Reviewed-by: Shu-yu Guo <syg@chromium.org>
    > Commit-Queue: Frank Tang <ftang@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82754}
    
    Bug: v8:11544
    Change-Id: Ia9d0a014463b00640d43b051753a554f42171c2b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858575Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82755}
    8ff03afe
temporal-parser.h 6.66 KB