• Seth Brenith's avatar
    [tools] Fix v8windbg behavior on Map's bit_field2 · 8b1a5681
    Seth Brenith authored
    Bill kindly pointed out to me that v8windbg was not handling bit_field2
    correctly. The issue was that the constexpr type for ElementsKind was,
    somewhat unsurprisingly, "ElementsKind", but v8windbg expected a fully-
    qualified type name like "v8::internal::ElementsKind". This change
    addresses the problem in two ways:
    1. Update v8windbg's type resolution logic to resolve type names as if
       they were used in the v8::internal namespace. This makes it more
       consistent with how those type names are used in other generated
       Torque code, reducing surprises and the number of times we have to
       write `v8::internal::` in .tq files.
    2. Add compile-time verification that any constexpr type name used as a
       string in class-debug-readers-tq.cc can also resolve as a type name.
    
    Bug: v8:9376
    Change-Id: I349cd6ab586fd8345a1fa8bfc3989bb8e6376ab8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063769Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#66633}
    8b1a5681
v8-debug-helper-interop.h 4.87 KB