• Tobias Tebbi's avatar
    [torque] avoid ambiguity if a catch catches from other handlers · 7e7b24eb
    Tobias Tebbi authored
    Torque desugars try-catch/label constructs with several handlers
    into nested try structures, with the first handler ending-up
    innermost. So currently, if you write
    
    try {
    ...
    } label Foo {
      Throw(...);
    } catch (e) {
    
    }
    
    The catch will catch the preceding Throw in another handler.
    This is different from how multiple try-catch handlers are done in
    languages like Java, where throwing from a preceding catch handler
    is not caught by a later one. To avoid this possible ambiguity, this
    CL prohibits this pattern, enforcing that a catch handler comes first,
    before any other label-handler attached to the same try.
    This way, a catch handler never catches from any other handler on the
    same try, since they have to come later.
    
    Bug: v8:7793
    Change-Id: I943f14b2393d307c4254a3fc3a78f236dbcf86df
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169098
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67516}
    7e7b24eb
promise-any.tq 14.9 KB