• clemensh's avatar
    [wasm] Make reported "lines" on stack frames 1-based · 0c6fa172
    clemensh authored
    In captured stack traces, all lines and columns must be 1-based.
    Even though this makes things a bit ugly, we have to comply also for
    wasm locations, where line and column encode function index and byte
    offset (both are originally 0-based).
    
    If we don't comply, the frontend might complain, as e.g. DevTools does.
    
    BUG=chromium:659715
    R=yangguo@chromium.org, kozyatinskiy@chromium.org
    CC=titzer@chromium.org
    
    Review-Url: https://codereview.chromium.org/2493943002
    Cr-Commit-Position: refs/heads/master@{#40971}
    0c6fa172
isolate.cc 119 KB