• Samuel Groß's avatar
    Harden Map.prototype.delete and related methods · 66c8de2c
    Samuel Groß authored
    These can be tricked into corrupting memory when an attacker can leak
    the "hole" value due to a bug. This CL simply adds CHECKs to prevent
    this. A longer-term solution might be to introduce "special-purpose
    holes" so that a leaked "hole" value can no longer be used to confuse
    unrelated code like the JSMap implementation because that would then use
    a different "hole" value.
    
    Bug: chromium:1315901
    Change-Id: Id6c432d39fb97002fa67efe90d34014fc5408ba3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593783Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80201}
    66c8de2c
builtins-collections-gen.cc 118 KB