• Nico Hartmann's avatar
    [Torque] Finalize torque-generated synchronized accessors · 8da583ee
    Nico Hartmann authored
    Torque-generated relaxed/acquire/release accessors now expect an
    additional Tag argument to be more consistent with handwritten
    accessors.
    
    Torque's annotations are renamed from @relaxedRead, @relaxedWrite,
    @acquireRead and @releaseWrite to @cppRelaxedLoad, @cppRelaxedStore,
    @cppAcquireLoad and @cppReleaseStore, repesectively. This renaming
    shall better reflect the fact that those annotations just generate
    corresponding synchronization on the generated C++ accessors
    (not CSA code) and be more consistent with the C++ side of things
    where "Load" and "Store" is used instead of "Read" and "Write".
    
    This CL uses these new annotations on a few fields in DebugInfo and
    FunctionTemplateInfo to have Torque generate accessors automatically.
    
    Bug: v8:11122
    Change-Id: Ibdf3e6b37a254605ff69ba9a50d7b1646790ea15
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876857Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74463}
    8da583ee
implementation-visitor.cc 208 KB