• Leszek Swirski's avatar
    [ignition] Skip binding dead labels · 35269f77
    Leszek Swirski authored
    BytecodeLabels for forward jumps may create a dead basic block if their
    corresponding jump was elided (due to it dead code elimination). We can
    avoid generating such dead basic blocks by skipping the label bind when
    no corresponding jump has been observed. This works because all jumps
    except JumpLoop are forward jumps, so we only have to special case one
    Bind for loop headers to bind unconditionally.
    
    Since Binds are now conditional on a jump existing, we can no longer rely
    on using Bind to get the current offset (e.g. at the beginning of a try
    block). Instead, we now expose the current offset in the bytecode array
    writer. Conveniently, this means that we can be a bit smarter about basic
    blocks around these statements.
    
    As a drive-by, remove the unused Bind(target,label) function.
    
    Bug: chromium:934166
    Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3
    Reviewed-on: https://chromium-review.googlesource.com/c/1488763
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59942}
    35269f77
IfConditions.golden 9.84 KB