• Deepti Gandluri's avatar
    Revert "[torque] Protect against printing Type* pointers" · 914d371f
    Deepti Gandluri authored
    This reverts commit ef808d3b.
    
    Reason for revert: Failures on TSAN: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/2981?
    
    Original change's description:
    > [torque] Protect against printing Type* pointers
    >
    > I've noticed a frequent mistake within Torque is to use Type* pointers
    > with ostream's operator<<, which causes it to print a hex pointer rather
    > than a descriptive string. This can cause confusing error messages for
    > users of the Torque compiler. This change is an idea to prevent future
    > incidences of that problem by adding a template overload that will cause
    > a compilation failure if anybody tries to use Type* in this way. It
    > found two incorrect uses of Type*, which I've corrected.
    >
    > Bug: v8:7793
    > Change-Id: I85fafb333a89f8a3fed4346bdd154d70846a63d1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748936
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#73574}
    
    Bug: v8:7793
    Change-Id: Ieee470aa3cd176b9e1ad21fe39b9939edcef5bd6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778722
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73576}
    914d371f
declaration-visitor.cc 15.2 KB