• Clemens Backes's avatar
    Revert "[wasm][debug] Fix tier down during streaming compilation" · 8d3cca97
    Clemens Backes authored
    This reverts commit 3cc981cb.
    
    Reason for revert: TSan failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/31572
    
    Original change's description:
    > [wasm][debug] Fix tier down during streaming compilation
    > 
    > If the debugger is enabled while streaming compilation is happening, we
    > won't correctly tier down to Liftoff. This is because during streaming
    > compilation, we always compile for no debugging. Fixing that is a bit
    > tricky, since when the debugger is enabled, functions can either already
    > have finished compiling, or they are currently being compiled, or their
    > wire bytes are not received yet.
    > Instead of handling this correctly while streaming compilation is
    > running, we just recompile the whole module with Liftoff after streaming
    > compilation finished.
    > 
    > For testing this, we use the existing tests for async compilation, and
    > enable --wasm-test-streaming, which compiles via the streaming decoder
    > even in the async compilation case.
    > 
    > R=​thibaudm@chromium.org
    > 
    > Bug: v8:10531
    > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67882}
    
    TBR=clemensb@chromium.org,thibaudm@chromium.org
    
    Change-Id: I26e750c6c6d0783b5e4a0f19a5462a5fbe99a742
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10531
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207186Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67885}
    8d3cca97
module-compiler.cc 116 KB