• Samuel Groß's avatar
    [base] Abort on unexpected failures in OS::SetPermissions · 18159ba6
    Samuel Groß authored
    It is expected that changing page permissions can fail due to the system
    running out of memory. However, any other failure is unexpected and
    likely indicates a bug in the caller, such as changing the permissions
    of an invalid memory region. To allow distinguishing between these
    unexpected failures and expected OOM failures, this CL adds CHECKs into
    the low-level memory management routines to abort when an unexpected
    failure occurs.
    
    Similar logic could later be added to other low-level memory management
    routines that can legitimately fail due to OOM as well.
    
    Bug: chromium:1320126
    Change-Id: I3de6f4b2aed8962c91770b81382df34384584501
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610445
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80245}
    18159ba6
v8-platform.h 39.3 KB