• Bill Budge's avatar
    Revert "Improve error messages for property access on null/undefined" · b261213f
    Bill Budge authored
    This reverts commit 24c626c1.
    
    Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail):
    https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109?
    
    Original change's description:
    > Improve error messages for property access on null/undefined
    >
    > Only print the property name when accessing null/undefined if we can
    > convert it to a string without causing side effects.
    > If we can't, omit the property name in the error message.
    > This should avoid confusion when the key is an object with toString().
    > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    > Object]' anymore, which was misleading since the property accessed would
    > be 'a', but we can't evaluate the key without side effects.
    >
    > Bug: v8:11365
    > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75250}
    
    Bug: v8:11365
    Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75282}
    b261213f
objects.h 33.9 KB