• Leszek Swirski's avatar
    Reland "[arm] Make the constant pool check deadline smarter" · a8f45786
    Leszek Swirski authored
    This is a reland of df4dae77
    
    Revert reason looks like an unrelated existing flake (https://crbug.com/v8/11634)
    
    Original change's description:
    > [arm] Make the constant pool check deadline smarter
    >
    > Rather than having periodic constant pool checks that almost always fail
    > (because the constant pool deadline isn't close enough, or even because
    > there's no constant pool to emit at all), set a single deadline on the
    > first constant pool insertion which expires just before the maximum
    > distance to the constant pool. Constant pool checks around unconditional
    > jumps happen irrespective of this deadline.
    >
    > In particular, this is made possible by fixing the incorrect assumption
    > that the constant pool can be emitted out of order. The new assumption
    > (that the emission is in-order) is validated with a CHECK.
    >
    > Bug: v8:11420
    > Change-Id: I061dd0b8c3476ba95ee1acfb3b485d8ba2adda91
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844665
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74141}
    
    Bug: v8:11420
    Change-Id: I1cc5ca9082da26ab225dee8d8ea22c385c6cc1d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848468
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#74154}
    a8f45786
assembler-arm.h 59.1 KB