• Kim-Anh Tran's avatar
    [debugger] Fix step out when instrumentation breaks are turned on · 51458608
    Kim-Anh Tran authored
    When triggering a step out action, we check whether we already
    are at a return or suspend location. If not, we first flood all
    return positions with breakpoints, set the fast_forward_to_return_
    flag and continue.
    
    With the new way of reporting instrumentation breakpoints, we now
    may get into the situation where we stopped on an instrumentation,
    but may still need to continue until we reach the return point for
    the step out. This CL fixes a bug in which we ran into a DCHECK
    that expected us to stop on a return location (since
    fast_forward_to_return_ is set to true), but we didn't.
    
    Drive-by: adapt other stepping tests to properly wait for all pauses
    
    Bug: chromium:1229541
    Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79226}
    51458608
debug.cc 109 KB