• Mythri A's avatar
    [csa][cleanup] TNodify StringAdd_CheckNone buitin · 452ca36b
    Mythri A authored
    StringAdd_CheckNone is called from Turbofan with an empty context. This
    builtin needs context when calling the StringAdd runtime function which
    could potentially throw. Turbofan does bounds check before calling this
    builtin so it is safe to pass an empty context. To enable TNodification
    of this builtin this cl adds a new type that either accepts a context
    or an empty context (Smi::Zero) and updates the builtin to use this new
    type.
    
    Bug: v8:6949, v8:11074
    Change-Id: Iff12b391ff95109649f2c81fe081e277850f60d6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523205
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71018}
    452ca36b
builtins-string-gen.h 8.91 KB