• Andreas Haas's avatar
    Reland [wasm] Check the result of Promise::Resolver · 42f285fc
    Andreas Haas authored
    The original CL was reverted because regression test used i18n stuff,
    which was not available in the no-i18n bot.
    
    The regression test turned out to be flaky, because I cannot even
    reproduce the crash now without the fix. I think the reason is that for
    the crash to happen a stack check has to fail within the rejection of
    a promise. Small changes can cause the stack check to fail somewhere
    else. Investigations showed though that the crash should still be
    possible. I propose therefore to land the fix now without the
    regression test.
    
    Original message:
    We check that if we do not get a result, or if we get a negative result,
    then there has to be a scheduled exception.
    
    R=clemensh@chromium.org
    BUG=chromium:704127
    
    Change-Id: Iaf355249686412a636074a476687413b621aac68
    Reviewed-on: https://chromium-review.googlesource.com/464846Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44300}
    42f285fc
wasm-js.cc 36.4 KB