• rmcilroy's avatar
    Replace DumpBacktrace with Chromium's StackTrace implementation. · 49c14f63
    rmcilroy authored
    Adds support for dumping the stack on Windows. Also enables in-process
    stack dumping in d8 to dump the stack on exceptions and signals.
    
    This CL changes the format of stack dumps from:
     1: V8_Fatal
     2: 0x1ac6ba5
     3: v8::internal::interpreter::BytecodeGenerator::Visit(v8::internal::AstNode*)
     4: v8::internal::interpreter::BytecodeGenerator::VisitForAccumulatorValue(v8::internal::Expression*)
     ...
    
    To:
      ./out/x64.debug/d8(v8::base::debug::StackTrace::StackTrace()+0x1e) [0x1c6ee5e]
      ./out/x64.debug/d8() [0x1c6ede5]
      /lib/x86_64-linux-gnu/libpthread.so.0(+0x10330) [0x7fa01193e330]
      ./out/x64.debug/d8(v8::base::OS::Abort()+0x12) [0x1c6cea2]
      ./out/x64.debug/d8() [0x1c67538]
      ./out/x64.debug/d8() [0x1ac80b5]
      ./out/x64.debug/d8(v8::internal::interpreter::BytecodeGenerator
    ::Visit(v8::internal::AstNode*)+0x3cb) [0x1ac323b]
      ./out/x64.debug/d8(v8::internal::interpreter::BytecodeGenerator
    ::VisitForAccumulatorValue(v8::internal::Expression*)+0x40) [0x1ac2570]
    
    Review-Url: https://codereview.chromium.org/2248393002
    Cr-Commit-Position: refs/heads/master@{#38717}
    49c14f63
logging.cc 2.23 KB