• Benedikt Meurer's avatar
    [inspector] Introduce v8::StackFrame::GetLocation() API. · ed7b6640
    Benedikt Meurer authored
    This introduces a new `GetLocation()` method for `v8::StackFrame`s,
    which returns both line and column number at the same time (using the
    existing `v8::Location` class). Since `v8::StackFrame` instances store
    only the source position (per https://bit.ly/v8-stack-frame), we
    currently need to look up the source position in the Script's line table
    twice, once when we request the line number, and another time when we
    request the column number.
    
    With `GetLocation()` we perform only a single lookup in the Script's
    line table and return both line and column number at the same time. This
    cuts roughly 8% of the average execution time from the `standalone.js`
    benchmark mentioned in crbug.com/1280519.
    
    Bug: chromium:1280519, chromium:1278650, chromium:1069425
    Bug: chromium:1077657, chromium:1283162
    Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    Change-Id: Ia3a0502990b6230363112a358b59875283399404
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359628Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78452}
    ed7b6640
api.cc 413 KB