• Samuel Groß's avatar
    [sandbox] Improve sandboxed pointer support · 549ee6f3
    Samuel Groß authored
    This CL removes the global IsValidBackingStorePointer function and turns
    the DCHECKs that ensure that sandboxed pointers point into the sandbox,
    which essentially cover the same condition, into CHECKs. This is mostly
    to facilitate debugging during the initial rollout, and the CHECKs can
    later be turned back into DCHECKs.
    
    In addition, this CL adds a fallback to a partially-reserved sandbox
    when sandboxed pointers are enabled and when the regular initialization
    fails.
    
    Bug: chromium:1218005
    Change-Id: I75526f1a00ddb9095ae0e797dc9bb80a210f867b
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3367617Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78620}
    549ee6f3
sandbox.h 7.04 KB