• Clemens Hammacher's avatar
    Speed up compilation and execution of CSA_ASSERTs · a7335920
    Clemens Hammacher authored
    Currently, each single CSA_ASSERT invokation creates its own lambda,
    which is then wrapped in a {std::function} and passed to
    {CodeStubAssembler::Assert}. It takes a lot of compile time for clang
    to generate all the code for that.
    This CL introduces a more light-weight alternative to
    {CodeStubAssembler::Assert} which just receives the node directly.
    This reduces compile time of {code-stub-assembler.cc} in optdebug mode
    from ~30 seconds to ~17 seconds locally.
    
    R=tebbi@chromium.org
    
    Bug: v8:7629
    Change-Id: I4520a7b587cb96319d75048cf11c1124be583d6a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724370Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62976}
    a7335920
code-stub-assembler.cc 530 KB