• Leszek Swirski's avatar
    [offthread] Fix flakiness with bg compile stress · 1a806198
    Leszek Swirski authored
    If we're close to a stack overflow when starting a script compile, we
    may get into a state where main-thread compilation would stack overflow,
    but background-thread compilation wouldn't. This triggers a failure of a
    CHECK under --stress-background-compile, but isn't actually an
    interesting failure.
    
    So, we loosen this CHECK to allow the main-thread having a stack
    overflow (strictly speaking, a RangeError) to count as a "success" for
    the purposes of comparing against a background compilation success.
    
    Bug: v8:10757
    Change-Id: I7d687b52d178973b421c42ca0d89b4da0357232a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320649
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69092}
    1a806198
compiler.cc 121 KB