• bakkot's avatar
    Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.... · a3c13435
    bakkot authored
    Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #2 id:170001 of https://codereview.chromium.org/2113593002/ )
    
    Reason for revert:
    WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests.
    
    Original issue's description:
    > Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ )
    >
    > Reason for revert:
    > Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/
    >
    > Original issue's description:
    > > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
    > >
    > > The spec was modified to relax some requirements which implementors had not been
    > > enforcing. Part of this process involved introducing a new abstract operation
    > > ToIndex, which had partial overlap with our existing semantics as well as some
    > > differences (most notably treating undefined as 0). Test262 tests were introduced to
    > > check for the new semantics, some of which we were failing. This patch amends the
    > > parts of our implementation corresponding to specification algorithms which use
    > > ToIndex to follow its semantics precisely.
    > >
    > > BUG=v8:4784,v8:5120
    > >
    > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
    > > Cr-Commit-Position: refs/heads/master@{#37406}
    >
    > TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=v8:4784,v8:5120
    >
    > Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f
    > Cr-Commit-Position: refs/heads/master@{#37417}
    
    TBR=littledan@chromium.org,adamk@chromium.org,hablich@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=v8:4784,v8:5120
    
    Review-Url: https://codereview.chromium.org/2247073004
    Cr-Commit-Position: refs/heads/master@{#38689}
    a3c13435
builtins-dataview.cc 5.14 KB