• Jungshik Shin's avatar
    Reland "[Intl] Move Number.toLocaleString from js to c++" · 65d0b783
    Jungshik Shin authored
    This reverts commit c83fae06.
    
    Reason for revert: the CL that required the revert of this CL was relanded.
    
    https://chromium-review.googlesource.com/c/v8/v8/+/1154247
    
    Original change's description:
    > Revert "[Intl] Move Number.toLocaleString from js to c++"
    >
    > This reverts commit a895f01a.
    >
    > Reason for revert: Needed for other revert:
    > https://chromium-review.googlesource.com/c/v8/v8/+/1152767
    >
    > Original change's description:
    > > [Intl] Move Number.toLocaleString from js to c++
    > >
    > >
    > > Bug: v8:7960
    > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    > > Change-Id: I21a524b620e210cce625a1a00e68c0b687187087
    > > Reviewed-on: https://chromium-review.googlesource.com/1144659
    > > Commit-Queue: Frank Tang <ftang@chromium.org>
    > > Reviewed-by: Jungshik Shin <jshin@chromium.org>
    > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#54741}
    >
    > TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org
    >
    > Change-Id: I060fa2834dde5e1b4cc71923cc066d97bce2a33b
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:7960
    > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    > Reviewed-on: https://chromium-review.googlesource.com/1152787
    > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54746}
    
    TBR=machenbach@chromium.org,jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:7960
    Change-Id: I7a7a67db77b9b5a181f1751a03186eb7e8b271a0
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1154248
    Commit-Queue: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54774}
    65d0b783
builtins-number.cc 9.54 KB