• ishell@chromium.org's avatar
    Reland^2 "[ext-code-space] Enable Code-less embedded builtins" · 91637c25
    ishell@chromium.org authored
    This is a reland of commit 40901824
    The reason for revert was regressions in `blink_gc:effective_size`
    buckets of `system_health.memory_desktop` benchmarks.
    See http://crbug/1356329#c51.
    
    Memory Perf Sheriffs: This CL shifts GC times which regresses
    `blink_gc:effective_size` but improves `v8:effective_size` bucket by
    a similar amount. The `private_footprint_size` metric stays neutral
    for the majority of the stories and for certain load stories it even
    improves.
    
    Original change's description:
    > [ext-code-space] Enable Code-less embedded builtins
    >
    > Bug: v8:11880, v8:12592
    > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593
    > Commit-Queue: Igor Sheludko <ishell@chromium.org>
    > Reviewed-by: Jakob Linke <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82642}
    
    Bug: v8:11880, v8:12592, chromium:1356329, chromium:1356763
    Change-Id: Ia9150ecb1f16581e249e4e3e566be20ac4591e78
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862503
    Auto-Submit: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82803}
    91637c25
globals.h 69.6 KB