• Shu-yu Guo's avatar
    [builtins] Use SetPropertyInLiteral instead of FastCreateDataProperty in Object.fromEntries · 1458040f
    Shu-yu Guo authored
    The spec uses the CreateDataProperty abstract operation to add
    properties to the result object of Object.fromEntries.
    
    Confusingly, the FastCreateDataProperty Torque macro is special-cased
    for adding array element properties instead of generic keyed properties.
    The slow path for FastCreateDataProperty goes to runtime, which was
    being hit everytime in Object.fromEntries since the result object is not
    an array.
    
    This CL switches to using StorePropertyInLiteral instead, which
    corresponds to the CreateDataProperty spec operation, and also has fast
    paths that stay in CSA.
    
    Bug: v8:11814
    Change-Id: I72a6809bde556f0888806307816e200bd47edf8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2915755Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74755}
    1458040f
object-fromentries.tq 2.77 KB