• sgjesse@chromium.org's avatar
    More precise break points and stepping when debugging · 634fb915
    sgjesse@chromium.org authored
    Added support for more precise break points when debugging and stepping. To achieve that additional nop instructions are inserted where breaking would otherwise be impossible. The number of nop instructions inserted are sufficient to make place for patching with a call to a debug break code stub. On Intel that is 5 nop's for 32-bit and 13 for 64-bit. Om ARM 3 nop instructions (12 bytes) are required.
    
    In order to avoid inserting nop's in to many places a simple ast checker have been added to check whether there are breakable code in a statement or expression. If it is possible to break in an expression no additional break enabeling code is inserted.
    
    Added break locations to the true and false part of a conditional expression.
    
    Added stepping tests to cover more constructs.
    
    These changes are only in the full compiler.
    
    Changed the default value for the option --debugger in teh d8 shell from true to false. The reason for this is that with --debugger turned on the full compiler will be used for all code in when running d8, which can be unexpeceted.
    
    Review URL: http://codereview.chromium.org/2693002
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    634fb915
codegen.cc 15.2 KB