• machenbach's avatar
    Revert of Resolve references to "this" the same way as normal variables... · 5cab6be8
    machenbach authored
    Revert of Resolve references to "this" the same way as normal variables (patchset #2 id:20001 of https://codereview.chromium.org/1130733003/)
    
    Reason for revert:
    [Sheriff] Breaks jetstream benchmark with errors like this:
    
    >>> Running suite: JetStream/bigfib.cpp
    >>> Stdout (#1):
    undefined:93: ReferenceError: this is not defined
      this['Module'] = Module;
      ^
    ReferenceError: this is not defined
        at eval (eval at __run (runner.js:13:3), <anonymous>:93:3)
        at eval (native)
        at __run (runner.js:13:3)
        at Object.runSimpleBenchmark (runner.js:44:31)
        at runner.js:97:13
    
    Original issue's description:
    > Resolve references to "this" the same way as normal variables
    >
    > Make the parser handle references to "this" as unresolved variables, so the
    > same logic as for the rest of function parameters is used for the receiver.
    > Minor additions to the code generation handle copying the receiver to the
    > context, along with the rest of the function parameters.
    >
    > Based on work by Adrian Perez de Castro <aperez@igalia.com>.
    >
    > BUG=v8:2700
    > LOG=N
    >
    > Committed: https://crrev.com/06a792b7cc2db33ffce7244c044a9c05afbb6116
    > Cr-Commit-Position: refs/heads/master@{#28263}
    
    TBR=rossberg@chromium.org,arv@chromium.org,wingo@igalia.com
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:2700
    
    Review URL: https://codereview.chromium.org/1129723003
    
    Cr-Commit-Position: refs/heads/master@{#28283}
    5cab6be8
contexts.cc 16.3 KB