• Leszek Swirski's avatar
    Reland "[offthread] Move stress-background-compile to compiler.cc" · 471b2001
    Leszek Swirski authored
    This is a reland of a441cbfb
    
    Disabling cctest/test-compiler/DeepEagerCompilationPeakMemory in stress
    mode since allocation is no longer deterministic.
    
    Original change's description:
    > [offthread] Move stress-background-compile to compiler.cc
    >
    > Make --stress-background-compile a V8 flag rather than a d8 flag, so
    > that it also tests unittests/cctests.
    >
    > Now, with this flag, every top-level script compile (that fulfills a
    > couple of restrictions) will be both main-thread and background-thread
    > compiled, taking the result of the background compile. In the future,
    > we'll probably want to verify that the two results are equivalent.
    >
    > One of the necessary changes to allow tests to pass was to introduce a
    > concept of a "temporary" script (with a temporary script id), which
    > doesn't get added to the script list. This is to avoid the main-thread
    > compile part of the stress-test having a debugger-visible side-effect,
    > e.g. in tests that enumerate scripts. We can't just create new ids for
    > such scripts, as then script-id expectation files no longer match.
    >
    > Bug: chromium:1011762
    > Change-Id: I500bbf2cabea762e69aca3dbae247daae71192cb
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120541
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67332}
    
    TBR=rmcilroy@chromium.org
    
    Bug: chromium:1011762
    Change-Id: I5f9f0eb71caa4829e72b4a6d2824cbebd3698bd5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162876Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67356}
    471b2001
script.h 8.45 KB