• Benedikt Meurer's avatar
    Revert "[inspector] Fix `Runtime.setMaxCallStackSizeToCapture`." · c51b582d
    Benedikt Meurer authored
    This reverts commit 34f73cc7.
    
    Reason for revert: Performance regressions throughout a lot of
    system health and browsing benchmarks.
    
    Original change's description:
    > [inspector] Fix `Runtime.setMaxCallStackSizeToCapture`.
    >
    > This change fixes the implementation of the previously introduced API
    > `Runtime.setMaxCallStackSizeToCapture` to work correctly and also apply
    > (consistently) to stack traces captured by V8 when exceptions are
    > thrown. It does so in a fully backwards compatible manner.
    >
    > This change thus makes the previous fix for catapult (which landed in
    > http://crrev.com/c/3347789) effective, and therefore ensures that real
    > world performance benchmarks aren't affected by the use of the `Runtime`
    > domain in the catapult test framework.
    >
    > Bug: chromium:1283162, chromium:1278650, chromium:1258599
    > Bug: chromium:1280803, chromium:1280832, chromium:1280818
    > Fixed: chromium:1280831
    > Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    > Change-Id: I4ec951a858317fa49096cd4023deb0104d92c9c9
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361839
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78458}
    
    Bug: chromium:1283162, chromium:1278650, chromium:1258599
    Bug: chromium:1280803, chromium:1280832, chromium:1280818
    Bug: chromium:1280831
    Change-Id: Id1efaffa2f7f08c47f833f68b8a297494edee21e
    Fixed: chromium:1283751, chromium:1283749, chromium:1283746
    Fixed: chromium:1283729, chromium:1283700, chromium:1283700
    Fixed: chromium:1283691, chromium:1283687, chromium:1283678
    Fixed: chromium:1283677, chromium:1283676, chromium:1283675
    Fixed: chromium:1283674, chromium:1283618, chromium:1283536
    Fixed: chromium:1283523, chromium:1283516
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364078
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78462}
    c51b582d
v8-inspector-impl.cc 19.6 KB