• Georg Neis's avatar
    [turbofan] Don't verify context input of Create*Context nodes · e33d6338
    Georg Neis authored
    The verifier tried to assert that the context input of Create*Context
    nodes has type OtherInternal (all Context constants have that type).
    This didn't quite work because of OSR values so actually it checked
    something much weaker. And what it checked still doesn't work because
    of dead code, in which the context input might statically be known to
    be the undefined value. I'm removing the assertion entirely now.
    
    I suspect that there are other assertions in the verifier that don't
    hold in the OSR code or in dead code. We are discussing a more general
    solution such as inserting TypeGuards in the relevant cases.
    
    Bug: chromium:1037771
    Change-Id: I6fb59c60e7120d5984ea0fe140269f2df6de8708
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010792
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Auto-Submit: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65871}
    e33d6338
verifier.cc 75.9 KB