• Maya Lekova's avatar
    Revert "[wasm] Store compile errors in CompilationState" · dd5c3631
    Maya Lekova authored
    This reverts commit bf3d7b9a.
    
    Reason for revert: Breaks TSAN build, see
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23248
    
    Original change's description:
    > [wasm] Store compile errors in CompilationState
    > 
    > We are currently storing compilation errors in the individual
    > compilation units and pass it to the ErrorThrower during finishing.
    > This CL changes that to store errors on the CompilationState directly.
    > From there, it is propagated to the ErrorThrower in the compilation
    > state callback.
    > This removes more work from the finisher task and slims down the
    > WasmCompilationUnits.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: v8:8343, v8:7921
    > Change-Id: Id332add43d4219d2a30fee653ed4e53a9b2698d9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1303720
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57091}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: Id32c7337494a4749485adbcfcaae7b2331afea66
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8343, v8:7921
    Reviewed-on: https://chromium-review.googlesource.com/c/1304544Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57094}
    dd5c3631
module-compiler.cc 123 KB