• Omer Katz's avatar
    [heap] Move use_lab_ to LinearAllocationArea · 856124c7
    Omer Katz authored
    The new PagedNewSpace composes a PagedSpaceBase subclass
    (PagedSpaceForNewSpace) to avoid a diamond inheritance since both
    PagedSpaceBase and NewSpace inherit from SpaceWithLinearArea.
    Both use the same LinearAllocationArea, LinearAreaOriginalData, and
    AllocationCounter, but use_lab_ remained a field of SpaceWithLinearArea.
    As a result, disabling inline allocations for new space only updated one
    of the use_lab_ instances (the one in PagedNewSpace) while allocations
    were using the other.
    Moving this field to LinearAllocationArea lets both use the same field
    and keep in sync.
    
    Bug: v8:12612
    Change-Id: I47eccc6444040efc3a3e5d93f6015fd2bdb611b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820065Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82315}
    856124c7
spaces.cc 16.5 KB