• Michael Lippautz's avatar
    Reland "[handles] Remove precise on-stack representation of global handles" · 65d43890
    Michael Lippautz authored
    This is a reland of commit 6953b555
    
    The reland fixes tests that retrieved the stack start from a
    non-inlined frame's fp. This does not work in certain configurations
    as the resulting marker is too low to consider the first local
    variables in subsequent calls.
    
    The fix uses an inline frame address for the tests to get an upper
    bound of stack addresses to consider.
    
    Original change's description:
    > [handles] Remove precise on-stack representation of global handles
    >
    > Since https://crrev.com/c/3806439 on-stack traced handles are marked
    > conservatively when being used in combination with CppHeap.
    >
    > This change removes the precise on-stack representation of the
    > internal traced nodes as they nodes would anyways be marked
    > conservatively. The effects are:
    > - cheaper representation (just a single node space);
    > - uniform handling: no checks to distinguish on-stack vs on-heap;
    > - no brittleness around cleaning on-stack handles when the event loop
    >  is empty;
    >
    > Change-Id: Id859623bfed77a66bdd064ea8065536264515eae
    > Bug: v8:13141
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812039
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82306}
    
    Bug: v8:13141
    Change-Id: I53ece36220e99d02be6df18f83c18450e5d5037b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820585Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82342}
    65d43890
embedder-tracing.cc 6.77 KB