• Samuel Groß's avatar
    [sandbox] Prepare ExternalPointerTable rollout · 8a59678b
    Samuel Groß authored
    This CL does the following:
    - It enables (i.e. allocates and initializes) the per-Isolate
      ExternalPointerTable when the sandbox is enabled.
    - It refactors the list of external pointer tags to mark them as
      "sandboxed" or "unsandboxed". An unsandboxed external pointer has a
      null tag.
    - It changes V8_SANDBOXED_EXTERNAL_POINTERS to now essentially just
      enable sandboxing for all available tags.
    - It modifies all low-level external pointer accessors to perform the
      ExternalPointerLookup only if the tag is non-zero and otherwise treat
      the slot as containing a raw pointer.
    
    This now allows rolling out external pointer sandboxing incrementally
    (separately for each external pointer type), which will in turn allow
    for more precise performance measurements of the impact of the sandbox.
    
    Note: when an external pointer tag is now marked as sandboxed (and
    V8_SANDBOXED_EXTERNAL_POINTERS is not enabled), the underlying slots are
    still 64-bits in size. This simplifies the implementation as we would
    otherwise need to deal with variably-sized external pointer slots. Local
    benchmarking suggests that the benefits from 32-bit external pointer
    slots are insignificant on typical benchmarks, so this should be ok.
    
    Drive-by: rename kExternalPointerSize to kExternalPointerSlotSize to
    make it more clear what it refers to (the on-heap storage size). Also
    delete CodeStubAssembler::InitializeExternalPointerField as it is not
    currently used and the implementation is fairly inefficient.
    
    Bug: v8:10391
    Change-Id: I7c38729c7e9048d737a1a8ced84749f5b1f7feab
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3736447Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81636}
    8a59678b
tnode.h 12.4 KB