• Simon Zünd's avatar
    [inspector] Introduce status result for Debugger.setScriptSource · 31850be1
    Simon Zünd authored
    This CL introduces a new `status` enum returned by setScriptSource.
    We'll use the information in the DevTools frontend to show more
    meaningful error messages as well as disambiguate compilation errors
    from failed live edits.
    
    Drive-by: Deprecate the sync and async stack traces in the result.
    Currently `setScriptSource` is guaranteed to stay paused so there
    is no need to send along the same information from the
    preceeding `Debugger.paused` event.
    In the future we will restart the top-most frame once we allow
    the top-most frame to be edited. In that case the inspector
    fires Debugger.resumed + Debugger.paused events following the
    live edit also making the info returned here superfluous.
    
    R=jarin@chromium.org
    
    Bug: chromium:1334484
    Change-Id: I4226491caed72013a00927273c523213d797a766
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691850
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81031}
    31850be1
v8-debugger-agent-impl.cc 79.6 KB