• Frank Tang's avatar
    Reland "[Intl] move localeCompare to C++" · 22c7dd2e
    Frank Tang authored
    This is a reland of 51ad234f
    
    With a manual layout rebaseline of js/fast/string-prototype-properties
    [1], this CL can be relanded without breaking the layout test.
    
    [1] https://chromium-review.googlesource.com/c/chromium/src/+/1154289
    also marks the test for skipping until this fix is rolled to Chromium.
    
    
    Original change's description:
    > [Intl] move localeCompare to C++
    >
    >
    > Bug: v8:7958
    > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    > Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa
    > Reviewed-on: https://chromium-review.googlesource.com/1144644
    > Commit-Queue: Frank Tang <ftang@chromium.org>
    > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54740}
    
    TBR=ftang@chromium.org, gsathya@chromium.org
    
    Bug: v8:7958
    Test: layout test: js/fast/string-prototype-properties
    Change-Id: Ic546349fcbc935917ded018801f7d942e50565d5
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1154247
    Commit-Queue: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54772}
    22c7dd2e
builtins-string.cc 21.2 KB