• Dan Elphick's avatar
    [compiler] Don't collect source positions when throwing exceptions · f12e8d64
    Dan Elphick authored
    While crrev.com/c/1520721 tried to avoid collecting source positions
    when throw exceptions, it failed because they were still collected in
    Isolate::CaptureStackTrace.
    
    This removes that collection point and lets SetStackFrameCacheCommon
    bail out when trying to set the stack frame cache for a bytecode that
    doesn't have source positions.
    
    It also adds tests that ensure source positions are not collected when
    an exception is thrown (although one is disabled as it does not yet
    work).
    
    Bug: v8:8510
    Change-Id: Id5caf579dda549d637fa9b3129c419d524be5ff2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565898
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60847}
    f12e8d64
isolate.cc 170 KB