• Deepti Gandluri's avatar
    Revert "Implement a fake virtual memory cage mechanism" · 1a0b993d
    Deepti Gandluri authored
    This reverts commit 1ea76c13.
    
    Reason for revert: The unit test added fails on the Fuchsia bot https://ci.chromium.org/p/v8/builders/ci/V8%20Fuchsia/25976?
    
    Original change's description:
    > Implement a fake virtual memory cage mechanism
    >
    > On operating systems where reserving virtual address space is expensive,
    > notably Windows pre 8.1, it is not possible to create a proper virtual
    > memory cage. In order to still be able to reference caged objects
    > through offsets from the cage base on these systems, this CL introduces
    > a fake cage mechanism. When the fake cage is used, most of the virtual
    > memory for the cage is not actually reserved. Instead, the cage's page
    > allocator simply relies on hints to the OS to obtain pages inside the
    > cage. This does, however, not provide the same security benefits as a
    > real cage as unrelated allocations might end up inside the cage.
    >
    > Bug: chromium:1218005
    > Change-Id: Ie5314be23966ed0042a017917b63595481b5e7e3
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217200
    > Commit-Queue: Samuel Groß <saelo@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77367}
    
    Bug: chromium:1218005
    Change-Id: I541bb9656ab2a6a080c2a30d372226fcc5c95391
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3219086
    Auto-Submit: Deepti Gandluri <gdeepti@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Owners-Override: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77368}
    1a0b993d
isolate-allocator.cc 8.17 KB